Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(handler): Create JsonSerializable handler #1486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scyzoryck
Copy link
Collaborator

@scyzoryck scyzoryck commented May 4, 2023

Q A
Bug fix? no
New feature? yes
Doc updated not yet
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

Why?

PHP provides nice interface to serialize data to Json, that is also fast. It works only in the serialization direction, there is no way to handle deserialization with it. In our benchmarks, after adding it to Author class we gained 15% faster serialization.

TODOs:

  • Get feedback
  • Add documentation

@goetas
Copy link
Collaborator

goetas commented May 5, 2023

This is a very nice addition. I think that it should be an opt in feature as it might be seen as a BC break if suddenly we start using it to decide what json serializeation should look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants