Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Doctrine mapped superclasses #1395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dontub
Copy link

@dontub dontub commented Mar 9, 2022

Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

This PR adds support for the mapped superclasses feature of Doctrine: https://www.doctrine-project.org/projects/doctrine-orm/en/2.11/reference/inheritance-mapping.html

@goetas
Copy link
Collaborator

goetas commented Aug 6, 2022

I'm confused by this MR. The serializer should already be able to serialize/deserialize parent classes. can you please provide more info on what is the use case?

@dontub
Copy link
Author

dontub commented Aug 9, 2022

Properties in parent classes are not handled for Doctrine entities. Without the change DoctrineDriverTest fails when a mapped superclass is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants