Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translation file if all translations removed #558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michealmouner
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Description

I added a part to delete all files that not exist in the generated domains anymore

scenario to reproduce

  • add new translation for new domain
  • dump translations (new domain created)
  • delete the translation
  • dump again

ER: the file deleted as domain not exist anymore
AR: the file exist

Todos

  • [ x ] Tests
  • Documentation
  • Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant