Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XliffLoader for format xlf instead of Symfony's loader #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dontub
Copy link

@dontub dontub commented Oct 12, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Description

The bundle's XliffLoader was only used if format was xliff, but not xlf. For xlf Symfony's loader was used instead. This resulted in lost attributes.

@dontub
Copy link
Author

dontub commented Jun 28, 2019

@gnat42 Do you think this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant