Updated InvalidateItem() to find multiple appearances

[RabidAnteater]

Fixes #52

InvalidateItem() only invalidates the first appearances of an item in the _itemIds list. If the item appears again in the list, the later appearances are not invalidated. This leads to 'ghost' items that cause problems with other parts of the script, such as ProcessItem().

e.g. An invalid item, a_itemId, appears in both Group 1 @ index 2 and Group 4 @ index 96.
_itemIds1.Find(a_itemId) returns 2 and sets _itemInvalidFlags1[2] = true. Processing stops and the instance in group 4 is not detected.

[RullGit]

Looks great.
I'd love to see a workaround for savegames with ghost items in them already, but this will at least prevent new games from corrupting!

So as review comment; please increase the CurrentVersion, check in OnVersionUpdate for version increases and invalidate everything.

[RabidAnteater]

This should also work to fix the issue mid-game and the testing I've done so far on broken saves seems to confirm this.

There is already a SKSE function that successfully finds invalid items and triggers the OnFoundInvalidItem event in this script. All my correction is doing is ensuring all the occurrences are flagged and not just the first.
The invalid items are still in the group, but are now ignored by the equip function and are eventually overwritten when the group fills up (more than 32 entries).

[RullGit]

I understand, they will indeed be found in the groupdata and reported as invalid. Nice.

[RullGit]

So, now, how to get this in a release? SkyUI hasn't been update for 4 to 6 years it seems. Do you have a compiled version of this?

[Mardoxx]

This repository doesn't have the most up to date code unfortunately

…

On Tue, 27 Apr 2021, 12:44 RullGit, ***@***.***> wrote: So, now, how to get this in a release? SkyUI hasn't been update for 4 to 6 years it seems. Do you have a compiled version of this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB2QMKVH3LOH3DWOJTT5HLTK2PQ3ANCNFSM42WZ7FIQ> .

[RabidAnteater]

I've asked Schlangster for permission to upload a compiled version of this Papyrus script to Nexus Mods. We'll see what comes of that.
All the info is here for people to compile themselves in Creation Kit, though (this script, at least seems to be the same as the SSE 5.2 version on Nexus).

[jrooke81]

Hello, what's the status of this PR? I'm currently having this issue in-game and its really frustrating, would be good to get this fix added.