Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N m holms #35

Merged
merged 9 commits into from
Aug 8, 2021
Merged

N m holms #35

merged 9 commits into from
Aug 8, 2021

Conversation

jcubic
Copy link
Contributor

@jcubic jcubic commented Aug 8, 2021

Collecting recipes by Nils M. Holm #34

@lassik
Copy link
Member

lassik commented Aug 8, 2021

Excellent work, thank you very much for taking on the task!

@lassik
Copy link
Member

lassik commented Aug 8, 2021

Can you add a # Title at the top of each .md file, and add the names of the new pages to www-index.scm?

@jcubic
Copy link
Contributor Author

jcubic commented Aug 8, 2021

Yes, will add the title. I've forgotten about that. Also will update index file.

@lassik
Copy link
Member

lassik commented Aug 8, 2021

Thanks! Can we rename the pages a bit for consistency?

  • Synchronize the title and filename for each page
  • Use imperative mood
  • Use similar titles for similar pages
recipes/find-substring-in-string.md 
# Find substring in string

recipes/split-list-into-groups-by-comparator.md 
# Split list into groups by comparator

recipes/use-list-as-stack.md 
# Use list as stack

recipes/use-list-as-queue.md 
# Use list as queue

The add-element-to-set page could perhaps be turned into a general "Use list as set" page, to match the stack and queue pages?

recipes/use-list-as-set.md
# Use list as set

@lassik lassik mentioned this pull request Aug 8, 2021
@jcubic
Copy link
Contributor Author

jcubic commented Aug 8, 2021

Can you check those that are in the PR, for now, let's merge those. I will check and search for the new recipe later.

Will create new PR with next batch.

@lassik
Copy link
Member

lassik commented Aug 8, 2021

Very good!

Can you add create-k-combinations-from-list to the index and add a # TItle to the .md file? Otherwise, ready to merge.

@lassik
Copy link
Member

lassik commented Aug 8, 2021

Nevermind, I can make a commit to add those things. Looks good, all in all!

@lassik lassik merged commit 6a7849e into master Aug 8, 2021
@lassik lassik deleted the n-m-holms branch August 8, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants