Skip to content

dep: Don't use broomdog via path #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2024
Merged

dep: Don't use broomdog via path #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/moongraph/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ tutorial = ["dep:aquamarine"]

[dependencies]
aquamarine = { version = "0.4.0", optional = true }
broomdog = { version = "0.1.1", path = "../../../broomdog" }
broomdog = { version = "0.1.1" }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run into an error with this? Maybe I had erroneously assumed that this would only use the path if it existed, but would otherwise load from crates.io?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you know this is probably just left over from when this crate lived in a workspace with others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building locally / from git, it didn't work as it didn't find it at the path.

dagga = { version = "0.2.1", default-features = false }
log = "0.4.17"
moongraph-macros = { path = "../moongraph-macros", version = "0.1.3", optional = true }
Expand Down
Loading