Check if column value is a null type when decoding historical data #58
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to checking if the column value is a string of 'null', also check if the column value is actually`null`.
This was referenced Dec 26, 2024
|
Thanks for adressing that! Would you please do the change requested by php-cs-fixer, then we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like with the recent changes to historical data, we should also be validating if OHLC data is actually
nullvs. just a string with null.In addition to checking if the column value is a string of 'null', also check if the column value is actually
null.This resolves issues for some securities where there's missing data (e.g. WBRPOX):