Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested IP whitelist #217

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

danielburger1337
Copy link
Contributor

Description

This PR introduces support for array values in the scheb_two_factor.ip_whitelist configuration option. This allows the user to specify the new-ish IpUtils::PRIVATE_SUBNETS constant together with some public IPs.

scheb_two_factor:
    # This already worked
    ip_whitelist: !php/const Symfony\Component\HttpFoundation\IpUtils::PRIVATE_SUBNETS

Now this works as well:

scheb_two_factor:
    ip_whitelist:
        - 9.9.9.9
        - [1.1.1.1, 1.0.0.1] 
        - !php/const Symfony\Component\HttpFoundation\IpUtils::PRIVATE_SUBNETS

@scheb scheb merged commit 94ded3b into scheb:7.x Jan 26, 2024
7 checks passed
@scheb
Copy link
Owner

scheb commented Jan 26, 2024

Thanks for contributing once again! 🙇

Released as v7.2.0

@danielburger1337 danielburger1337 deleted the extended-ip-whitelist branch January 31, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants