Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed nodeType dependency on scenery #588

Merged
merged 2 commits into from
May 7, 2024
Merged

fix: removed nodeType dependency on scenery #588

merged 2 commits into from
May 7, 2024

Conversation

smlpt
Copy link
Contributor

@smlpt smlpt commented Apr 23, 2024

Scenery removed the Node.nodeType property in version 0.11.2. This PR fixes the occurrences of nodeType in Sciview and uses java classes instead, which is what @skalarproduktraum suggested.

@smlpt smlpt added the bugfix This PR contains a bugfix label Apr 23, 2024
skalarproduktraum
skalarproduktraum approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@skalarproduktraum skalarproduktraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @smlpt 👍

@skalarproduktraum skalarproduktraum merged commit 435e6e5 into main May 7, 2024
4 checks passed
@skalarproduktraum skalarproduktraum deleted the fix/node-type-compatability branch May 7, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skalarproduktraum skalarproduktraum skalarproduktraum approved these changes

@kephale kephale Awaiting requested review from kephale

Assignees
No one assigned
Labels
bugfix This PR contains a bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smlpt @skalarproduktraum