Update Fiji more nicely #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fijiUpdate task was using update-force-pristine which forcibly resets all the JAR versions to those currently on the sciview update site. So, if you do a populate, and then change something in sciview, and then another populate... the second populate will cause many MB worth of stuff to be redownloaded and overwrite your previous testing version... only to then copy in a new testing version again. :face_palm: So this commit switches from update-force-pristine to a normal update, which will decline to overwrite the "locally modified" JARs. The goal is to make the populate/test/edit loop less slow and wasteful. This change could potentially result in a not-clean Fiji state from which we then attempt to upload if, for example, you populate, then remove a dependency, then populate again. In such a situation, the Fiji.app would still have that old dependency as a "local only" file, and then fijiUpload would subsequently upload it to the update site.
skalarproduktraum
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
update-force-pristine, which clobbers any previously populated new version of sciview in favor of the older currently-on-the-sciview-update-site files, let's use the regularupdatedirective, which updates new core libraries, but does not overwrite "Locally modified" files with their older counterparts.And while at it, let's improve a few other things about the fiji* tasks.