Add Atmosphere background shader to the scene #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
What scenery version should we try (jitpack or whatever)? I tried 9062d7f but that doesn't seem to build on jitpack. |
|
I got this working with scenery = The inspector UI was working, key controls, etc. It all looks good! |
Glad to hear that, thanks! |
# Conflicts: # build.gradle.kts
smlpt
requested review from
kephale and
skalarproduktraum
and removed request for
kephale and
skalarproduktraum
kephale
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to add an atmosphere background from the "Add" menu to the scene.
The atmosphere exposes three parameters in the inspector:
Latitude: The current latitude of the user to display the correct sun direction based on the local timeEnable keybindings and manual control: a checkbox to attach/detach keybindings. This allows the user to move the sun around with Ctrl + arrow keys and Ctrl + Shift + arrow keys for fast and slow movement respectivelyEmission Strength: change the brightness of the background with a default strength of 1.This will currently require the functionality of the scenery atmosphere-shader branch that has not been merged yet.
Edit: the scenery branch has changed to this one