GLFWMouseAndKeyHandler: fix #377 in windows every click registers as … #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…left click and no scrolling. There were a few values in the wrong places.
|
button2 and button3 do not map to the correct buttons |
moreApi
force-pushed
the
fix/windows-mouse-click-scroll
branch
from
d3bda7c
to
29c803d
Compare
…ed an wrong initial value in mask translation
moreApi
force-pushed
the
fix/windows-mouse-click-scroll
branch
from
708832f
to
63a5cd2
Compare
|
they do now. Also the test that never worked corretly works now like it should ... i hope |
skalarproduktraum
requested changes
Sep 17, 2024
There was a problem hiding this comment.
One small change/correction, otherwise it looks good to me 👍 Thanks, @moreApi!
skalarproduktraum
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…left click and no scrolling. There were a few values in the wrong places.