Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atmosphere azimuth range and declination formula #764

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

smlpt
Copy link
Contributor

@smlpt smlpt commented Jun 21, 2024

Azimuth range was -180-180, which conflicted with the more common range 0-360 that is set as a sciview property for the inspector.
Declination calculation has also been fix and show be more accurate now.

@smlpt smlpt added the bugfix PR contains a bugfix label Jun 21, 2024
Copy link
Member

@kephale kephale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smlpt smlpt merged commit 1814f15 into main Jun 24, 2024
5 of 6 checks passed
@smlpt smlpt deleted the fix/atmosphere-azimuth branch June 25, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR contains a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants