Remove waiting period when closing #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gracePeriod variable only decreases in the main loop while it is looping. But the `shouldClose = true` causes the main loop to stop looping. So the gracePeriod only had time to decrement once (to 59), at which point the while loop here in the `close()` function gets stuck. It may be the case that this looping was only necessary for the OpenGL renderer anyway, which is no longer an issue, so we can simplify now.
skalarproduktraum
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gracePeriod variable only decreases in the main loop while it is
looping. But the
shouldClose = truecauses the main loop to stoplooping. So the gracePeriod only had time to decrement once (to 59),
at which point the while loop here in the
close()function gets stuck.It may be the case that this looping was only necessary for the OpenGL
renderer anyway, which is no longer an issue, so we can simplify now.