Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origin/Volume: Introduce support for custom origins and use in Volume #733

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Origin/Volume: Introduce support for custom origins and use in Volume #733

merged 2 commits into from
Apr 17, 2024

Conversation

skalarproduktraum
Copy link
Member

This PR introduces a new option for setting custom origins of Volumes. Supercedes #731.

@skalarproduktraum skalarproduktraum added the enhancement Issue or PR discusses an enhancement label Apr 17, 2024
smlpt
smlpt requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@smlpt smlpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one question

src/main/kotlin/graphics/scenery/volumes/Volume.kt Show resolved Hide resolved
@skalarproduktraum skalarproduktraum merged commit e89f9d6 into main Apr 17, 2024
6 checks passed
@skalarproduktraum skalarproduktraum deleted the feature/custom-volume-origins-new branch April 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlpt smlpt smlpt approved these changes

@moreApi moreApi Awaiting requested review from moreApi

@kephale kephale Awaiting requested review from kephale

Assignees
No one assigned
Labels
enhancement Issue or PR discusses an enhancement prague-hackathon-2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skalarproduktraum @smlpt