Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume: Introduce ray shuffling to limit banding artifacts #709

Merged
merged 9 commits into from
Apr 17, 2024

Conversation

skalarproduktraum
Copy link
Member

This PR adds shuffling to cast rays in order to reduce banding artifacts.

@skalarproduktraum skalarproduktraum marked this pull request as ready for review April 15, 2024 16:10
@skalarproduktraum skalarproduktraum requested review from aryaman-gupta and moreApi and removed request for aryaman-gupta April 16, 2024 16:02
skalarproduktraum added a commit to scenerygraphics/sciview that referenced this pull request Apr 16, 2024
… colormaps if given colormap is not found in LUTService
skalarproduktraum added a commit to scenerygraphics/sciview that referenced this pull request Apr 16, 2024
Copy link
Member

@kephale kephale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on BDVExample and ProceduralVolumeExample and the viz looks great.

Many examples have the wrong path for the volumes

@skalarproduktraum
Copy link
Member Author

@kephale the paths are not wrong, I have updated the demo models zip file yesterday, with flybrain.zip and t1-head.zip:
image

@kephale
Copy link
Member

kephale commented Apr 17, 2024

Ahh, yeah I have an old model directory. Another reason to autodownload :D

@skalarproduktraum skalarproduktraum merged commit cbb12c9 into main Apr 17, 2024
6 checks passed
@skalarproduktraum skalarproduktraum deleted the feature/improved-volume-sampling branch April 17, 2024 14:18
skalarproduktraum added a commit to scenerygraphics/sciview that referenced this pull request Apr 18, 2024
skalarproduktraum added a commit to scenerygraphics/sciview that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants