Curve restructuring #529
Open
Curve restructuring #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he frenet frame calculation into another class.
… and normal calculation into an interface.
…n extra interface.
…urve abstract so that now the baseShapes can be configurated with more constraints
…ics/scenery into curve_restructuring Merge the updated revision of the 'drop operator' and the visibility change
skalarproduktraum
requested changes
Nov 6, 2023
src/main/kotlin/graphics/scenery/geometry/curve/BaseShapesFromSingleShape.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/graphics/scenery/geometry/curve/FrenetFrameCalculation.kt
Outdated
Show resolved
Hide resolved
* MathLine renamed to PositionDirection, with arguments interchanged * FrenetOrientedCurve renamed to FrenetCurve * Calculation (CurveGeometryCalculation, FrenetFrameCalculation) objects removed and merged into FrenetCurve and DefaultCurve * PartialCurveMesh renamed to PartialCurve * inheritance patterns improved in SingleMeshCurve, PartialCurve, Helix and DefaultCurve
skalarproduktraum
approved these changes
Mar 14, 2024
…ullingMode material properties
skalarproduktraum
force-pushed
the
curve_restructuring
branch
2 times, most recently
from
7df3882
to
177673a
Compare
skalarproduktraum
force-pushed
the
curve_restructuring
branch
from
177673a
to
ba1e1fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reorders the Curve class. Specifically, it breaks it down into an Interface and an abstract class. This allows for more flexibility. In our case, it allows the user to choose a single base shape or if they want to trade more flexibly for a slightly worse performance.
Also cleaned up the code a bit, for example, put the coverOrTop attribute into an enum.