don't use same object reference in shallow dep info #66

justinwoo · 2023-08-16T14:36:09Z

this causes us to create an invalid parent node that does not parse as a valid request in the API, due to the shared grandparent node being modified:

scarf-js/report.js

Lines 118 to 128 in 8bade0e

    
           delete (dependencyInfo.rootPackage.packageJsonPath) 
        
           delete (dependencyInfo.rootPackage.path) 
        
           delete (dependencyInfo.rootPackage.name) 
        
           delete (dependencyInfo.rootPackage.version) 
        
           delete (dependencyInfo.parent.path) 
        
           delete (dependencyInfo.scarf.path) 
        
           if (dependencyInfo.grandparent) { 
        
             delete (dependencyInfo.grandparent.path) 
        
             delete (dependencyInfo.grandparent.name) 
        
             delete (dependencyInfo.grandparent.version) 
        
           }

fixes problems from #60

this causes us to create an invalid parent node that does not parse as a valid request in the API, due to the shared grandparent node being modified: https://github.com/scarf-sh/scarf-js/blob/8bade0e1b1ed705305e016f480beac36abef4cc0/report.js#L118-L128

alexbiehl

Good catch!

justinwoo requested a review from aviaviavi August 16, 2023 14:36

alexbiehl approved these changes Aug 16, 2023

View reviewed changes

aviaviavi approved these changes Aug 16, 2023

View reviewed changes

aviaviavi merged commit ba916b8 into master Aug 16, 2023
15 checks passed

aviaviavi deleted the dont-use-shared-reference-parent-grandparent-skip-traversal branch August 16, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't use same object reference in shallow dep info #66

don't use same object reference in shallow dep info #66

justinwoo commented Aug 16, 2023

alexbiehl left a comment

	delete (dependencyInfo.rootPackage.packageJsonPath)
	delete (dependencyInfo.rootPackage.path)
	delete (dependencyInfo.rootPackage.name)
	delete (dependencyInfo.rootPackage.version)
	delete (dependencyInfo.parent.path)
	delete (dependencyInfo.scarf.path)
	if (dependencyInfo.grandparent) {
	delete (dependencyInfo.grandparent.path)
	delete (dependencyInfo.grandparent.name)
	delete (dependencyInfo.grandparent.version)
	}

don't use same object reference in shallow dep info #66

don't use same object reference in shallow dep info #66

Conversation

justinwoo commented Aug 16, 2023

alexbiehl left a comment

Choose a reason for hiding this comment