Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update note on allowTopLevel behavior #62

Merged
merged 1 commit into from
Aug 12, 2023
Merged

update note on allowTopLevel behavior #62

merged 1 commit into from
Aug 12, 2023

Conversation

justinwoo
Copy link
Contributor

Just a small note on the gitSha reporting change, but I think this should wait until we have a real release and handle the gitSha events on the API side.

aviaviavi
aviaviavi approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@aviaviavi aviaviavi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'm trying to get the release ready to go now, I'm not sure I see the benefit to waiting for backend API changes, what did you have in mind there? I don't think this is blocked on that, we can always send data that the server isn't yet expecting.

@aviaviavi aviaviavi merged commit b5b937d into master Aug 12, 2023
6 checks passed
@aviaviavi aviaviavi deleted the document-gitsha branch August 12, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviaviavi aviaviavi aviaviavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinwoo @aviaviavi