Adds skip snippet and scanoss setting feature #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustingroh
force-pushed
the
feat/groh/Add-skip-snippet-flag
branch
from
d8d3e3b to
b4b18a1
Compare
| export const RUNTIME_CONTAINER = tl.getInput('runtimeContainer') || "ghcr.io/scanoss/scanoss-py:v1.18.0"; | ||
| export const SKIP_SNIPPETS = tl.getInput('skipSnippets') === 'true'; | ||
| export const SCAN_FILES = tl.getInput('scanFiles') === 'true'; | ||
| export const SCANOSS_SETTINGS = tl.getInput('scanossSettings') === 'true'; |
There was a problem hiding this comment.
Here maybe we should do a check for the RUNTIME_CONTAINER
We should only allow to pass SCANOSS_SETTINGS and SETTINGS_FILE_PATH if the scanoss.py version supports it
There was a problem hiding this comment.
Every Azure task has pingued an scanoss-py version. We shouldn´t have to check for the RUNTIME_CONTAINER
| private buildArgs(): Array<string> { | ||
| return ['run', '-v', `${REPO_DIR}:/scanoss`, RUNTIME_CONTAINER, 'inspect', 'undeclared', '--input', | ||
| OUTPUT_FILEPATH, '--format', 'md', | ||
| ...(!SCANOSS_SETTINGS ? ['--sbom-format', 'legacy']: []) // Sets sbom format output to legacy if SCANOSS_SETTINGS is not true |
There was a problem hiding this comment.
What happens if default SBOM_FILEPATH does not exists and SCANOSS_SETTINGS is false? We should pass --sbom-format anyways?
There was a problem hiding this comment.
If the SBOM_FILEPATH has a default value set. If the file is not found and the SCANOSS_SETTINGS is set to false, we use the legacy sbom format
eeisegn
approved these changes
Nov 15, 2024
agustingroh
force-pushed
the
feat/groh/Add-skip-snippet-flag
branch
from
258488b to
63ca94c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What