fix: log4j appender throwing null pointer exception #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of the log4j ScalyrAppender, the
getLayout()
method will always returnnull
because the layout is not being read. This occurs because therequiresLayout()
method is set to returnfalse
in ScalyrAppender. As a result, even if a layout is configured for this appender in the logger configuration, it will not be utilized. To fix this issue, therequiresLayout()
method should returntrue
, allowing the layout to be read and applied properly.For reference, see the Appender class in Apache Log4j where
requiresLayout()
is used to determine if a layout is required.