chore: update actions images

.github/actions/cypress-cache/action.yaml

@@ -4,7 +4,7 @@ runs:
   using: "composite"
   steps:
     # cache cypress runner 
-    - uses: actions/cache@v3
+    - uses: actions/cache@v4
       id: cypress-cache
       with:
         path: /home/runner/.cache/Cypress

.github/actions/lint/action.yaml

@@ -3,7 +3,7 @@ description: verify linting rules
 runs:
   using: "composite"
   steps:
-    - uses: nrwl/nx-set-shas@v3
+    - uses: nrwl/nx-set-shas@v4
     - uses: './.github/actions/node-cache'
     - name: Install deps
       shell: bash

.github/actions/node-cache/action.yaml

@@ -4,7 +4,7 @@ runs:
   using: "composite"
   steps:
     # cache node modules for all jobs to use
-    - uses: actions/cache@v3
+    - uses: actions/cache@v4
       id: node_modules-cache
       with:
         path: | 

.github/actions/release/action.yaml

@@ -17,9 +17,9 @@ runs:
   using: "composite"
   steps:
     - name: Use Node.js
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
-        node-version: '18'
+        node-version: '20'
     - uses: './.github/actions/node-cache'
     - name: Install deps
       shell: bash

.github/actions/test-e2e/action.yaml

@@ -3,7 +3,7 @@ description: verify e2e tests
 runs:
   using: "composite"
   steps:
-    - uses: nrwl/nx-set-shas@v3
+    - uses: nrwl/nx-set-shas@v4
     - uses: './.github/actions/node-cache'
     - uses: './.github/actions/cypress-cache'
     - uses: './.github/actions/webpack-cache'
@@ -13,4 +13,10 @@ runs:
     - name: Run e2e tests
       shell: bash
       run: npm run test:e2e
+    - name: Upload test results
+      uses: actions/upload-artifact@v4
+      if: failure()
+      with:
+        name: test-results
+        path: dist/cypress/examples/test-app-e2e/screenshots/
 

.github/actions/test-unit/action.yaml

@@ -3,7 +3,7 @@ description: verify unit tests
 runs:
   using: "composite"
   steps:
-    - uses: nrwl/nx-set-shas@v3
+    - uses: nrwl/nx-set-shas@v4
     - uses: './.github/actions/node-cache'
     - name: Install deps
       shell: bash

.github/actions/webpack-cache/action.yaml

@@ -4,7 +4,7 @@ runs:
   using: "composite"
   steps:
     # cache node modules for all jobs to use
-    - uses: actions/cache@v3
+    - uses: actions/cache@v4
       id: webpack-cache
       with:
         path: | 

.github/workflows/ci.yml

@@ -10,10 +10,10 @@ jobs:
   install:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: nrwl/nx-set-shas@v3
+      - uses: nrwl/nx-set-shas@v4
       # cache node modules for all jobs to use
       - uses: './.github/actions/node-cache'
       # cache cypress runner
@@ -24,26 +24,26 @@ jobs:
     needs: [install]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: './.github/actions/lint'
   test:
     runs-on: ubuntu-latest
     needs: [install]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: './.github/actions/test-unit'
   build:
     runs-on: ubuntu-latest
     needs: [install]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: nrwl/nx-set-shas@v3
+      - uses: nrwl/nx-set-shas@v4
       - uses: './.github/actions/node-cache'
       - name: Install deps
         run: npm i
@@ -53,7 +53,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [install, build]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: './.github/actions/test-e2e'
@@ -62,7 +62,7 @@ jobs:
     needs: [install, lint, test, build, test-e2e]
     if: github.event_name != 'pull_request'
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           ssh-key: ${{ secrets.BOTH_AUTH_KEY }}

e2e-script.js

@@ -14,7 +14,16 @@ try {
 }
 
 // ensure the deps exist before we start the servers
-execSync('npm run build', { cwd: cdnPath, stdio: 'inherit'})
+execSync('npm run build -c webpack.config.js', { cwd: cdnPath, stdio: 'inherit'})
+
+console.log('Dist dir of assets:')
+execSync('ls -la dist', { cwd: cdnPath, stdio: 'inherit'})
+console.log('Root dir of assets:')
+execSync('ls -la .', { cwd: cdnPath, stdio: 'inherit'})
+console.log('Root dir:')
+execSync('ls -la', { cwd: __dirname, stdio: 'inherit'})
+console.log('Packages dist dir:')
+execSync('ls -la dist/packages', { cwd: __dirname, stdio: 'inherit'})
 
 const {result, commands} = concurrently(
   [{
@@ -29,7 +38,7 @@ const {result, commands} = concurrently(
   }, {
     cwd: __dirname,
     name: 'e2e',
-    command: 'npx wait-on federation-cdn-mock/dist http://localhost:4200 http://localhost:8001 -i 2000 && npx nx run test-app-e2e:e2e --skipNxCache',
+    command: 'npx wait-on http://localhost:4200 http://127.0.0.1:8001 && npx nx run test-app-e2e:e2e --skipNxCache',
   }],
   {
     successCondition: 'e2e',

examples/test-app-e2e/src/e2e/test-app/module-loading-errors.cy.ts

@@ -3,7 +3,7 @@ describe('Module error loading handling', () => {
     cy.visit('http://localhost:4200/legacy');
 
     // intercept webpack chunk and return 500 response
-    cy.intercept('GET', 'http://localhost:8001/exposed-./PreLoadedModule.js', {
+    cy.intercept('GET', 'http://127.0.0.1:8001/exposed-./PreLoadedModule.js', {
       statusCode: 500,
     });
 

examples/test-app/src/entry.tsx

@@ -14,12 +14,12 @@ const config: AppsConfig<{ assetsHost?: string }> = {
   notFound: {
     name: 'notFound',
     manifestLocation: '/assets/testPath/foo/bar/nonsense.json',
-    assetsHost: 'http://localhost:8888',
+    assetsHost: 'http://127.0.0.1:8001',
   },
   'sdk-plugin': {
     name: 'sdk-plugin',
-    assetsHost: 'http://localhost:8001',
-    manifestLocation: 'http://localhost:8001/plugin-manifest.json',
+    assetsHost: 'http://127.0.0.1:8001',
+    manifestLocation: 'http://127.0.0.1:8001/plugin-manifest.json',
   },
 };
 

federation-cdn-mock/src/index.tsx

@@ -0,0 +1,2 @@
+// just a mock for webpack
+// it tends to generate empty assets on CI without explicit entry

federation-cdn-mock/webpack.config.js

@@ -2,6 +2,8 @@ const { resolve } = require('path');
 const { ModuleFederationPlugin, ContainerPlugin } = require('@module-federation/enhanced');
 const { DynamicRemotePlugin } = require('@openshift/dynamic-plugin-sdk-webpack');
 
+console.log("Entry tests:", resolve(__dirname, './src/modules/moduleOne.tsx'))
+
 const sharedModules = {
   react: {
     singleton: true,
@@ -54,7 +56,9 @@ const TestSDKPLugin = new DynamicRemotePlugin({
 function init() {
   /** @type { import("webpack").Configuration } */
   const config = {
-    entry: {},
+    entry: {
+      mock: resolve(__dirname, './src/index.tsx'),
+    },
     cache: { type: 'filesystem', cacheDirectory: resolve(__dirname, '.cdn-cache')},
     output: {
       publicPath: 'auto',