Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/s3 utils 158/storage consumption metrics #312

Merged

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented May 13, 2024

This PR aims to provide monitoring metrics for the count items cron-job.
Today the metrics that have been put in place are :

  • bucketCount : Total number of buckets

  • bucketProcessingDuration : Duration of processing a bucket

  • consolidationDuration : Duration of metrics consolidation in seconds

  • workersCount : a metric that shows success / errors during the workers count

  • objectsCount : Number of objects based on their states

  • metricsCount : Number of buckets ( none empty) , number of accounts with buckets , and number of locations

  • It also puts in place a job stop mecanism resumed with :
    ==> If the job completed and the scraping occured => immediate stop
    ==> Otherwise we wait for a duration ( threshold x frequency x 4 x 1000 ) if a scraping occurs during it we stop otherwise we wait for the whole duration then we stop the job

Note for reviewers : this is a first iteration as the job has never been monitored ( only alerts were put in place ) please let me know if you see that some metrics might make more sens / or others are not really needed

Linked issue : https://scality.atlassian.net/browse/S3UTILS-158

@bert-e
Copy link
Contributor

bert-e commented May 13, 2024

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@benzekrimaha benzekrimaha force-pushed the feature/S3UTILS-158/storage-consumption-metrics branch 9 times, most recently from 892877a to 6252082 Compare May 14, 2024 07:26
@benzekrimaha benzekrimaha marked this pull request as ready for review May 14, 2024 07:40
@scality scality deleted a comment from bert-e May 14, 2024
@bert-e
Copy link
Contributor

bert-e commented May 14, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@benzekrimaha benzekrimaha force-pushed the feature/S3UTILS-158/storage-consumption-metrics branch from 6252082 to 905181b Compare May 14, 2024 07:54
utils/monitoring.js Outdated Show resolved Hide resolved
utils/monitoring.js Outdated Show resolved Hide resolved
utils/monitoring.js Outdated Show resolved Hide resolved
utils/monitoring.js Outdated Show resolved Hide resolved
utils/monitoring.js Outdated Show resolved Hide resolved
utils/monitoring.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
CountItems/masterProcess.js Outdated Show resolved Hide resolved
@benzekrimaha benzekrimaha force-pushed the feature/S3UTILS-158/storage-consumption-metrics branch 2 times, most recently from 7c957f3 to 5b7f15a Compare May 14, 2024 15:05
CountItems/CountManager.js Outdated Show resolved Hide resolved
CountItems/CountManager.js Outdated Show resolved Hide resolved
CountItems/CountManager.js Outdated Show resolved Hide resolved
CountItems/CountManager.js Outdated Show resolved Hide resolved
utils/monitoring.js Outdated Show resolved Hide resolved
utils/monitoring.js Outdated Show resolved Hide resolved
utils/S3UtilsMongoClient.js Outdated Show resolved Hide resolved
utils/constants.js Outdated Show resolved Hide resolved
utils/monitoring.js Outdated Show resolved Hide resolved
CountItems/CountMaster.js Outdated Show resolved Hide resolved
@benzekrimaha benzekrimaha force-pushed the feature/S3UTILS-158/storage-consumption-metrics branch 2 times, most recently from b34c8b0 to a50c483 Compare May 15, 2024 14:13
Copy link
Contributor

@williamlardier williamlardier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment as discussed: we need to set the counters/gauges to 0 at the beginning of a count-items run, otherwise the values will only increase

@benzekrimaha benzekrimaha force-pushed the feature/S3UTILS-158/storage-consumption-metrics branch 2 times, most recently from fb1a8f6 to dba0c98 Compare May 16, 2024 15:04
@benzekrimaha benzekrimaha force-pushed the feature/S3UTILS-158/storage-consumption-metrics branch from 57e2d47 to 7a54697 Compare May 16, 2024 15:36
@benzekrimaha benzekrimaha force-pushed the feature/S3UTILS-158/storage-consumption-metrics branch from 98cc347 to bc28c67 Compare May 16, 2024 16:17
@benzekrimaha
Copy link
Contributor Author

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented May 16, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.13
  • development/1.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented May 16, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@benzekrimaha
Copy link
Contributor Author

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented May 16, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.13
  • development/1.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented May 16, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests, create_integration_branches

@benzekrimaha
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e May 16, 2024
@bert-e
Copy link
Contributor

bert-e commented May 16, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.14

  • ✔️ development/1.15

The following branches have NOT changed:

  • development/1.13
  • development/1.4

Please check the status of the associated issue S3UTILS-158.

Goodbye benzekrimaha.

The following options are set: approve, create_pull_requests, create_integration_branches

@bert-e bert-e merged commit bc28c67 into development/1.14 May 16, 2024
10 checks passed
@bert-e bert-e deleted the feature/S3UTILS-158/storage-consumption-metrics branch May 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants