quadiron integration #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrancurel
force-pushed
the
feat/quadiron-fnt
branch
2 times, most recently
from
4b9d6ff
to
63d230a
Compare
lamphamsy
reviewed
Dec 17, 2018
vrancurel
force-pushed
the
feat/quadiron-fnt
branch
from
63d230a
to
18ad2e8
Compare
vrancurel
force-pushed
the
feat/quadiron-fnt
branch
from
18ad2e8
to
1d414d6
Compare
vrancurel
force-pushed
the
feat/quadiron-fnt
branch
2 times, most recently
from
4ebab59
to
195a52d
Compare
slaperche-scality
suggested changes
Feb 7, 2019
|
|
||
| int quadiron_fnt_exit(void *desc) | ||
| { | ||
| quadiron_fnt_descriptor *quadiron_fnt_desc = NULL; |
There was a problem hiding this comment.
Why initialize to NULL? You're setting a value just below.
|
|
||
| size_t quadiron_fnt_common_get_metadata_size(void *desc, int block_size) | ||
| { | ||
| quadiron_fnt_descriptor *quadiron_fnt_desc = NULL; |
| void * quadiron_fnt_common_init(struct ec_backend_args *args, void *backend_sohandle, | ||
| int systematic) | ||
| { | ||
| quadiron_fnt_descriptor *desc = NULL; |
| quadiron_fnt_descriptor *desc = NULL; | ||
|
|
||
| desc = (quadiron_fnt_descriptor *)malloc(sizeof(quadiron_fnt_descriptor)); | ||
| if (NULL == desc) { |
There was a problem hiding this comment.
No need for Yoda-condition with modern compiler (same remark apply below).
| goto error; | ||
| } | ||
|
|
||
| func_handle.vptr = dlsym(backend_sohandle, "quadiron_hex_dump"); |
There was a problem hiding this comment.
No func_handle.vptr = NULL; before? No NULL check after?
The function get_data_ptr_from_fragment() actually returns a pointer to the metadata header. In most of the code it is the expected behavior but in fragments_to_string() we want the actual content without the metadata. Creation of a new function prefixed by _ to address this particular case.
The code already has some logic to support more than 32 fragments (bitvalues) but it is currently not fully functional. This changeset brings full support to backends supporting more than 32 fragments, especially by changing from bitmaps to bitvalues in some specific functions.
QuadIron is an open source library that supports a large number of parities in a systematic or non-systematic setting. This changeset also include the proper unit tests to validate the new backend.
vrancurel
force-pushed
the
feat/quadiron-fnt
branch
2 times, most recently
from
a6420ca
to
dfb5e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.