Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELENG-7422] 📝 Add documentation #42

Merged
merged 24 commits into from
Jun 27, 2023

Conversation

gaspardmoindrot
Copy link
Contributor

No description provided.

@gaspardmoindrot gaspardmoindrot requested a review from a team as a code owner June 15, 2023 17:42
@gaspardmoindrot gaspardmoindrot self-assigned this Jun 15, 2023
@gaspardmoindrot gaspardmoindrot marked this pull request as draft June 15, 2023 17:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #42 (096fee9) into main (6f4b71e) will increase coverage by 1.29%.
The diff coverage is 97.76%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   96.15%   97.44%   +1.29%     
==========================================
  Files          10       14       +4     
  Lines         442      509      +67     
==========================================
+ Hits          425      496      +71     
+ Misses         17       13       -4     
Flag Coverage Δ
api 97.36% <97.62%> (?)
unit 19.41% <37.11%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gh_actions_exporter/main.py 96.07% <88.23%> (-1.49%) ⬇️
gh_actions_exporter/metrics.py 92.24% <91.89%> (+3.90%) ⬆️
tests/api/metrics/test_job.py 98.80% <98.80%> (ø)
gh_actions_exporter/Webhook.py 100.00% <100.00%> (ø)
gh_actions_exporter/config.py 97.22% <100.00%> (+0.44%) ⬆️
gh_actions_exporter/cost.py 100.00% <100.00%> (ø)
gh_actions_exporter/types.py 100.00% <100.00%> (ø)
tests/api/conftest.py 100.00% <100.00%> (ø)
tests/api/metrics/conftest.py 100.00% <100.00%> (ø)
tests/api/metrics/test_workflow.py 100.00% <100.00%> (ø)
... and 2 more

Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a very good piece of doc, but some of the content are specific to us (scality) and this is a public project.

Keeping this in mind you have to write the doc in the context of the project itself:

  • it does not know about gcp or aws, but a quick mention can be added
  • large xlarge etc labels are only used in our context or depending how users have configured their github org

docs/setup/collected-reported-metrics.md Outdated Show resolved Hide resolved
docs/setup/collected-reported-metrics.md Outdated Show resolved Hide resolved
docs/setup/collected-reported-metrics.md Outdated Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@gaspardmoindrot gaspardmoindrot marked this pull request as ready for review June 15, 2023 23:37
docs/tags.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
@gaspardmoindrot
Copy link
Contributor Author

I mimicked the syntax present in the devdocs repository, but unfortunately, trunk check is causing issues here. I will find a solution. If I try other methods, it still doesn't work, either in terms of the display or with trunk.

@gaspardmoindrot
Copy link
Contributor Author

I ended up using <!-- trunk:ignore --> after all; I couldn't find any other solution.

docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
docs/metrics-analysis-prometheus/prometheus.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're very close to merge this one, checkout the open conversation (one may be hidden as it's outdated) and we're good to go 🚀

Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still one open conversation.

@gaspardmoindrot
Copy link
Contributor Author

still one open conversation.

There were 2 of them open, I just noticed the other one, I'll take care of it.

@gaspardmoindrot gaspardmoindrot merged commit 44ba76b into main Jun 27, 2023
6 checks passed
@gaspardmoindrot gaspardmoindrot deleted the improvement/RELENG-7422-add-documentation branch June 27, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants