-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELENG-7422] 📝 Add documentation #42
[RELENG-7422] 📝 Add documentation #42
Conversation
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 96.15% 97.44% +1.29%
==========================================
Files 10 14 +4
Lines 442 509 +67
==========================================
+ Hits 425 496 +71
+ Misses 17 13 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a very good piece of doc, but some of the content are specific to us (scality) and this is a public project.
Keeping this in mind you have to write the doc in the context of the project itself:
- it does not know about gcp or aws, but a quick mention can be added
- large xlarge etc labels are only used in our context or depending how users have configured their github org
I mimicked the syntax present in the |
I ended up using |
Co-authored-by: Thomas Carmet <[email protected]>
Co-authored-by: Thomas Carmet <[email protected]>
Co-authored-by: Thomas Carmet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're very close to merge this one, checkout the open conversation (one may be hidden as it's outdated) and we're good to go 🚀
Co-authored-by: Thomas Carmet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still one open conversation.
There were 2 of them open, I just noticed the other one, I'll take care of it. |
Co-authored-by: Thomas Carmet <[email protected]>
No description provided.