Feature/s3 c 9226 create bucket #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Dockerfile, Makefile and CI workflows - Added tests for DriverInfo in identity server Issue: S3C-9222
- Updated provisioner to implement create bucket functionality - Added an S3 client to interact with S3 - Added logs to the methods not implemented yet - Added placeholder for accepting TLS certificates for S3 endpoint. Issue: S3C-9226
anurag4DSB
force-pushed
the
feature/S3C-9226-create-bucket
branch
from
8b756c6
to
70f9c8e
Compare
fredmnl
reviewed
Sep 17, 2024
go.mod
Outdated
| ) | ||
|
|
||
| require ( | ||
| github.com/aws/aws-sdk-go v1.55.5 |
There was a problem hiding this comment.
The AWS recommendation is to move to V2 https://github.com/aws/aws-sdk-go-v2, end of support is in less than a year for V1.
| @@ -0,0 +1,120 @@ | |||
| /* | |||
| @@ -0,0 +1,5317 @@ | |||
| // Code generated by MockGen. DO NOT EDIT. | |||
There was a problem hiding this comment.
We should at least document how this is generated, for repeatability. How about adding it in the build step of the Makefile?
jonathan-gramain
approved these changes
Sep 24, 2024
pkg/driver/provisioner.go
Outdated
| return s3Client, nil | ||
| } | ||
|
|
||
| func fetchS3Parameters(secretData map[string][]byte) (string, string, string, string, string, error) { |
There was a problem hiding this comment.
May be worth creating a private type s3Params struct{ AccessKey string ...} returned by this function.
pkg/util/s3client/s3-handler.go
Outdated
| } | ||
|
|
||
| // configureTLSTransport sets up the HTTP transport with TLS support | ||
| func configureTLSTransport(certData []byte, skipTLS bool) *http.Transport { |
There was a problem hiding this comment.
Suggested change
| func configureTLSTransport(certData []byte, skipTLS bool) *http.Transport { | |
| func configureTLSTransport(certData []byte, skipVerify bool) *http.Transport { |
anurag4DSB
force-pushed
the
feature/S3C-9222-setup-CI
branch
from
610ef55
to
45bc875
Compare
|
As too much rework is needed, I am gonna divide this into 2 PRs
First PR: #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: Create Bucket using provisioner