Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST AuthV4 #5666

Merged
merged 2 commits into from
Aug 28, 2024
Merged

POST AuthV4 #5666

merged 2 commits into from
Aug 28, 2024

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Aug 23, 2024

Bump vaultclient, this will use POST by default when issuing AuthV4 internal requests (verifySignatureV4) with a security token (unbounded) or request contexts (same, but here it authorizes as well).

Fixes issues when any of those is too long for the backend to handle (as nodejs imposes max lengths for the http GET requests).

-> No new branch for now, as there is no breaking change in this service, but only vaultclient...

@bert-e
Copy link
Contributor

bert-e commented Aug 23, 2024

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 23, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-557 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.8.31

Please check the Fix Version/s of CLDSRV-557, or the target
branch of this pull request.

@williamlardier williamlardier changed the title Improvement/cldsrv 557 POST AuthV4 Aug 23, 2024
package.json Outdated Show resolved Hide resolved
@williamlardier
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Aug 28, 2024
@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.8

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7

Please check the status of the associated issue CLDSRV-557.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit 055f9f4 into development/8.8 Aug 28, 2024
16 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-557 branch August 28, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants