Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/cldsrv 548 flag update oplog #5613

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Jul 2, 2024

This PR aims to introduce a flag that will be used by Arsenal to introduce a hack to write the MD twice in the oplog: one "deleted: true" copy of the previous MD, followed by the expected update with the new metadata.

Issue: CLDSRV-548

@bert-e
Copy link
Contributor

bert-e commented Jul 2, 2024

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jul 2, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-548 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.8.27

Please check the Fix Version/s of CLDSRV-548, or the target
branch of this pull request.

package.json Outdated
@@ -21,7 +21,7 @@
"dependencies": {
"@azure/storage-blob": "^12.12.0",
"@hapi/joi": "^17.1.0",
"arsenal": "git+https://github.com/scality/arsenal#8.1.130",
"arsenal": "git+https://github.com/scality/arsenal#1f20fe0fdbc0aa55ef71a4c870cd9230f75d494d",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project version will be bumped once arsn released

@benzekrimaha benzekrimaha marked this pull request as ready for review July 2, 2024 06:41
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-548-flag-update-oplog branch from 41ae9cd to 8a39e45 Compare July 2, 2024 06:46
@@ -193,6 +193,10 @@ function createAndStoreObject(bucketName, bucketMD, objectKey, objMD, authInfo,
metadataStoreParams.oldReplayId = objMD.uploadId;
}

if (objMD && !bucketMD.isVersioningEnabled() && objMD.archive && Object.keys(objMD.archive).length > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This handles the case of bucket without versioning ; we may however have the same issue in version suspended case ? @Kerkesni, is there maybe already a function to check if we are in these kind of condition?
  • no reason to check Object.keys(objMD.archive) : we should simply check if the object has been written to "cold", i.e. objMD?.archive?.archiveInfo (and you must not check the content of archiveInfo, it is supposed to stay opaque: hence the type any in arsenal's ObjectMDArchive)

AFAIR, race conditions (e.g. object deleted/replaced/...) during the archival process should be handled already when finishing the transition : if the object does not exist (or etag does not match), backbeat will post a Delete/GC request back to tape I think...

Copy link
Contributor

@Kerkesni Kerkesni Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the function isVersioningEnabled

    isVersioningEnabled() {
        const versioningConfig = this.getVersioningConfiguration();
        return versioningConfig ? versioningConfig.Status === 'Enabled' : false;
    }

This should handle the versioning suspended case also. (returns false when the bucket is non versioned and when it's in versioning suspended mode)

@bert-e
Copy link
Contributor

bert-e commented Jul 4, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-548 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.8.28

Please check the Fix Version/s of CLDSRV-548, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Jul 8, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha benzekrimaha changed the base branch from development/8.8 to bugfix/CLDSRV-555-deleteObjects-policy-eval-fix July 15, 2024 11:09
@benzekrimaha benzekrimaha force-pushed the bugfix/CLDSRV-555-deleteObjects-policy-eval-fix branch from 12f67b3 to dbf5332 Compare July 15, 2024 11:57
@benzekrimaha benzekrimaha changed the base branch from bugfix/CLDSRV-555-deleteObjects-policy-eval-fix to development/8.8 July 15, 2024 11:57
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-548-flag-update-oplog branch from 6d56c4b to 9fab537 Compare July 15, 2024 13:00
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-548-flag-update-oplog branch 2 times, most recently from 140b5fd to d851a2c Compare July 15, 2024 13:22
package.json Outdated
@@ -21,7 +21,7 @@
"dependencies": {
"@azure/storage-blob": "^12.12.0",
"@hapi/joi": "^17.1.0",
"arsenal": "git+https://github.com/scality/arsenal#8.1.130",
"arsenal": "git+https://github.com/scality/arsenal#817bb836ec0e04fbf083b4c57e42e3986dcdc9bc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder to bump before merging

@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-548-flag-update-oplog branch from 998f405 to 4af00b3 Compare July 18, 2024 15:26
@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jul 18, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.8

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7

Please check the status of the associated issue CLDSRV-548.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit 4af00b3 into development/8.8 Jul 18, 2024
16 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-548-flag-update-oplog branch July 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants