Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDSRV-412 Test null version in Lifecycle list of non-current versions #5231

Merged
merged 2 commits into from
Jul 14, 2023
Merged

CLDSRV-412 Test null version in Lifecycle list of non-current versions #5231

merged 2 commits into from
Jul 14, 2023

Conversation

nicolas2bert
Copy link
Contributor

@nicolas2bert nicolas2bert commented Jul 12, 2023 •
edited
Loading

Testing this change: scality/Arsenal#2150

@bert-e
Copy link
Contributor

bert-e commented Jul 12, 2023

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jul 12, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-412 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.6.10

  • 8.7.25

  • 8.8.0

Please check the Fix Version/s of CLDSRV-412, or the target
branch of this pull request.

@nicolas2bert nicolas2bert mentioned this pull request Jul 13, 2023
Merged
@bert-e
Copy link
Contributor

bert-e commented Jul 14, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-412 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.6.10

  • 8.7.25

  • 8.8.1

Please check the Fix Version/s of CLDSRV-412, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Jul 14, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jul 14, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

naren-rajendran
naren-rajendran reviewed Jul 14, 2023
View reviewed changes
tests/functional/backbeat/listDeleteMarker.js
const testBucket = 'bucket-for-list-lifecycle-current-dm-tests';
const keyName = 'key0';

before(done => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick :) may be before and after sections can be reused (convert into a generic fn perhaps) for both these test groups with an option to delete object. This is no way a necessity, just an observation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the “before” functions are different. Not sure we can “generate” them

@nicolas2bert
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Jul 14, 2023

Build failed

The build for commit did not succeed in branch w/8.8/bugfix/CLDSRV-412/null.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 14, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.6

  • ✔️ development/8.7

  • ✔️ development/8.8

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 14, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.6

  • ✔️ development/8.7

  • ✔️ development/8.8

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue CLDSRV-412.

Goodbye nicolas2bert.

@bert-e bert-e merged commit ee84a03 into development/8.6 Jul 14, 2023
21 of 23 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-412/null branch July 14, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderchan-scality alexanderchan-scality alexanderchan-scality approved these changes

@naren-rajendran naren-rajendran naren-rajendran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas2bert @bert-e @alexanderchan-scality @naren-rajendran