Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDSRV390: bump mongodb to 4.4 #5170

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented May 23, 2023

No description provided.

@bert-e
Copy link
Contributor

bert-e commented May 23, 2023

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 23, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-390 contains:

  • 8.7.19

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.21

Please check the Fix Version/s of CLDSRV-390, or the target
branch of this pull request.

@williamlardier williamlardier marked this pull request as draft May 23, 2023 13:41
@francoisferrand
Copy link
Contributor

francoisferrand commented Jun 21, 2023

IMHO this does not require a new branch:

  • the code is compatible, there is no actual change: i.e. mongo 4.4 was already supported (and both 4.2 and 4.0 are still supported)
  • ideally we would "validate" the component against different versions of mongo, i.e. 4.0, 4.2 and 4.4 at the moment (possibly in post-merge / nightly / weekly, this is low risk i believe)
  • this may be a much larger change, which does not fit this ticket ; but just bump to mongo 4.4 on existing branch is acceptable in the mean time : anyway, all components are tested together in zenko, and we don't use specific feature of mongo...

@bert-e
Copy link
Contributor

bert-e commented Jun 21, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-390 contains:

  • 8.7.19

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.25

  • 8.8.0

Please check the Fix Version/s of CLDSRV-390, or the target
branch of this pull request.

@williamlardier williamlardier marked this pull request as ready for review June 22, 2023 14:55
@williamlardier williamlardier changed the base branch from development/8.7 to development/8.8 June 22, 2023 14:55
@williamlardier williamlardier force-pushed the improvement/CLDSRV-390-bump-mongodb-to-4.4 branch from 5d752d7 to 0b58b3a Compare June 22, 2023 14:57
@scality scality deleted a comment from bert-e Jun 22, 2023
@bert-e
Copy link
Contributor

bert-e commented Jun 22, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 22, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.8

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 22, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.8

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7

Please check the status of the associated issue CLDSRV-390.

Goodbye williamlardier.

@bert-e bert-e merged commit 0b58b3a into development/8.8 Jun 22, 2023
@bert-e bert-e deleted the improvement/CLDSRV-390-bump-mongodb-to-4.4 branch June 22, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants