Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): disable input on disabled sliders #4669

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Now, when a slider is disabled, its related input(s) is(are) in a disabled state : it is still not possible to edit the slider value(s) anymore.

@lisalupi lisalupi added the bug Something isn't working label Jan 15, 2025
@lisalupi lisalupi requested a review from a team January 15, 2025 16:51
@lisalupi lisalupi self-assigned this Jan 15, 2025
@lisalupi lisalupi requested a review from matthprost as a code owner January 15, 2025 16:51
@lisalupi lisalupi requested review from johnrazeur and DorianMaliszewski and removed request for a team January 15, 2025 16:51
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 1f96604

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (9db9273) to head (1f96604).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4669      +/-   ##
==========================================
+ Coverage   87.65%   87.70%   +0.05%     
==========================================
  Files         341      341              
  Lines       12899    12911      +12     
  Branches     3519     3520       +1     
==========================================
+ Hits        11306    11323      +17     
+ Misses       1593     1588       -5     
Files with missing lines Coverage Δ
.../src/components/Slider/components/DoubleSlider.tsx 81.59% <ø> (ø)
.../src/components/Slider/components/SingleSlider.tsx 94.62% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a90434...1f96604. Read the comment docs.

@lisalupi lisalupi merged commit 8219a68 into main Jan 16, 2025
15 checks passed
@lisalupi lisalupi deleted the fix/slider-input-disabled branch January 16, 2025 14:00
@scaleway-bot scaleway-bot mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants