fix(NumberInputV2): styling when disabled #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisalupi
requested review from
johnrazeur,
a team and
matthprost
as code owners
🦋 Changeset detectedLatest commit: aa1ea28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4668 +/- ##
==========================================
+ Coverage 87.65% 87.70% +0.05%
==========================================
Files 341 341
Lines 12899 12913 +14
Branches 3519 3521 +2
==========================================
+ Hits 11306 11325 +19
+ Misses 1593 1588 -5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
matthprost
approved these changes
Jan 15, 2025
johnrazeur
approved these changes
Jan 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
There was a problem with the border of
NumberInputV2when it was disabled or read-only.Relevant logs and/or screenshots
Before:
After:
