feat: add popoverMaxHeight to TagList #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radhi-nasser-scaleway
requested review from
matthprost and
lisalupi
as code owners
🦋 Changeset detectedLatest commit: 2a936db The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
radhi-nasser-scaleway
force-pushed
the
DS-1153
branch
from
b126317 to
eaabed0
Compare
radhi-nasser-scaleway
force-pushed
the
DS-1153
branch
from
eaabed0 to
708454d
Compare
matthprost
requested changes
Jan 13, 2025
radhi-nasser-scaleway
force-pushed
the
DS-1153
branch
from
708454d to
0005613
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4661 +/- ##
==========================================
+ Coverage 87.65% 87.70% +0.05%
==========================================
Files 341 341
Lines 12899 12911 +12
Branches 3519 3521 +2
==========================================
+ Hits 11306 11323 +17
+ Misses 1593 1588 -5
Continue to review full report in Codecov by Sentry.
|
radhi-nasser-scaleway
force-pushed
the
DS-1153
branch
2 times, most recently
from
f0120fe to
9c0ae47
Compare
lisalupi
approved these changes
Jan 15, 2025
matthprost
requested changes
Jan 15, 2025
matthprost
approved these changes
Jan 15, 2025
radhi-nasser-scaleway
force-pushed
the
DS-1153
branch
from
5b3b25c to
2a936db
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Add
popoverMaxHeighttoTagListRelevant logs and/or screenshots