Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): thumb position #4637

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Slider): thumb position #4637

wants to merge 1 commit into from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Jan 3, 2025

Summary

Type

  • Bug

Summarise concisely:

What is expected?

The thumb of the double slider was not centered on firefox when there was a tooltip. Fixed it
Before :
Capture d’écran 2025-01-03 à 18 06 19
After :
Capture d’écran 2025-01-03 à 18 06 26

@lisalupi lisalupi requested a review from a team January 3, 2025 17:07
@lisalupi lisalupi self-assigned this Jan 3, 2025
@lisalupi lisalupi requested review from alexandre-combemorel and radhi-nasser-scaleway and removed request for a team January 3, 2025 17:07
@lisalupi lisalupi requested a review from matthprost as a code owner January 3, 2025 17:07
Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: dbda512

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (2205ef6) to head (dbda512).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4637   +/-   ##
=======================================
  Coverage   87.43%   87.44%           
=======================================
  Files         335      335           
  Lines       12722    12730    +8     
  Branches     3471     3522   +51     
=======================================
+ Hits        11124    11132    +8     
  Misses       1598     1598           
Files with missing lines Coverage Δ
.../src/components/Slider/components/DoubleSlider.tsx 81.59% <100.00%> (+0.46%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c3416...dbda512. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants