doc(instance_server): mark private_ip as deprecated (#2852)

* doc(instance_server): mark private_ip as deprecated * fix link * add deprecation notice in schema
scaleway · Dec 17, 2024 · ce02850 · ce02850
1 parent 52518dc
commit ce02850
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/resources/instance_server.md b/docs/resources/instance_server.md
@@ -286,8 +286,8 @@ In addition to all arguments above, the following attributes are exported:
 - `placement_group_policy_respected` - True when the placement group policy is respected.
 - `root_volume`
     - `volume_id` - The volume ID of the root volume of the server.
-- `private_ip` - The Scaleway internal IP address of the server.
-- `public_ip` - The public IP address of the server (Deprecated use `public_ips` instead).
+- `private_ip` - The Scaleway internal IP address of the server (Deprecated use [ipam_ip datasource](../data-sources/ipam_ip.md#instance-private-network-ip) instead).
+- `public_ip` -  The public IP address of the server (Deprecated use `public_ips` instead).
 - `public_ips` - The list of public IPs of the server.
     - `id` - The ID of the IP
     - `address` - The address of the IP

diff --git a/internal/services/instance/server.go b/internal/services/instance/server.go
@@ -189,6 +189,7 @@ func ResourceServer() *schema.Resource {
 				Type:        schema.TypeString,
 				Computed:    true,
 				Description: "The Scaleway internal IP address of the server",
+				Deprecated:  "Use ipam_ip datasource instead to fetch your server's IP in your private network.",
 			},
 			"public_ip": {
 				Type:        schema.TypeString,