test(k8s): fix naming + pn error in nightly tests (#2511)

* rename pool tests

* set delete_additional_resources to false in all tests

* cassettes

* cassettes

* fix 500 errors

internal/services/k8s/cluster_data_source_test.go

@@ -34,7 +34,7 @@ func TestAccDataSourceCluster_Basic(t *testing.T) {
 						version = "%s"
 						cni     = "cilium"
 					  	tags    = [ "terraform-test", "data_scaleway_k8s_cluster", "basic" ]
-						delete_additional_resources = true
+						delete_additional_resources = false
 						private_network_id = scaleway_vpc_private_network.main.id
 					}
 

internal/services/k8s/cluster_test.go

@@ -610,7 +610,7 @@ resource "scaleway_k8s_cluster" "minimal" {
 	version = "%s"
 	name = "test-minimal"
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "minimal" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.minimal.id
 }`, version)
 }
@@ -639,7 +639,7 @@ resource "scaleway_k8s_cluster" "autoscaler" {
 		max_graceful_termination_sec = 1337
 	}
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "autoscaler-config" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.autoscaler.id
 }`, version)
 }
@@ -666,7 +666,7 @@ resource "scaleway_k8s_cluster" "autoscaler" {
 		max_graceful_termination_sec = 2664
 	}
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "autoscaler-config" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.autoscaler.id
 }`, version)
 }
@@ -688,7 +688,7 @@ resource "scaleway_k8s_cluster" "oidc" {
 		groups_prefix = "pouf"
 	}
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "oidc-config" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.oidc.id
 }
 `, version)
@@ -711,7 +711,7 @@ resource "scaleway_k8s_cluster" "oidc" {
 		username_prefix = "boo"
 	}
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "oidc-config" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.oidc.id
 }
 `, version)
@@ -732,7 +732,7 @@ resource "scaleway_k8s_cluster" "auto_upgrade" {
 		maintenance_window_day = "%s"
 	}
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "auto_upgrade" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.auto_upgrade.id
 }`, version, enable, hour, day)
 }
@@ -779,7 +779,7 @@ resource "scaleway_k8s_cluster" "multicloud" {
 	version = "%s"
 	cni = "kilo"
 	type = "multicloud"
-	delete_additional_resources = true
+	delete_additional_resources = false
 }
 
 resource "scaleway_k8s_pool" "multicloud" {

internal/services/k8s/pool_data_source_test.go

@@ -35,7 +35,7 @@ func TestAccDataSourcePool_Basic(t *testing.T) {
 						version = "%s"
 						cni     = "cilium"
 					  	tags    = [ "terraform-test", "data_scaleway_k8s_pool", "basic" ]
-						delete_additional_resources = true
+						delete_additional_resources = false
 						private_network_id = scaleway_vpc_private_network.main.id
 					}
 					
@@ -58,7 +58,7 @@ func TestAccDataSourcePool_Basic(t *testing.T) {
 						version = "%s"
 						cni     = "cilium"
 					  	tags    = [ "terraform-test", "data_scaleway_k8s_cluster", "basic" ]
-						delete_additional_resources = true
+						delete_additional_resources = false
 						private_network_id = scaleway_vpc_private_network.main.id
 					}
 

internal/services/k8s/pool_test.go

@@ -19,7 +19,7 @@ import (
 	vpcgwchecks "github.com/scaleway/terraform-provider-scaleway/v2/internal/services/vpcgw/testfuncs"
 )
 
-func TestAccCluster_PoolBasic(t *testing.T) {
+func TestAccPool_Basic(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -83,7 +83,7 @@ func TestAccCluster_PoolBasic(t *testing.T) {
 	})
 }
 
-func TestAccCluster_PoolWait(t *testing.T) {
+func TestAccPool_Wait(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 	latestK8SVersion := testAccK8SClusterGetLatestK8SVersion(tt)
@@ -162,7 +162,7 @@ func TestAccCluster_PoolWait(t *testing.T) {
 	})
 }
 
-func TestAccCluster_PoolPlacementGroup(t *testing.T) {
+func TestAccPool_PlacementGroup(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -219,7 +219,7 @@ func TestAccCluster_PoolPlacementGroup(t *testing.T) {
 	})
 }
 
-func TestAccCluster_PoolUpgradePolicy(t *testing.T) {
+func TestAccPool_UpgradePolicy(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -274,7 +274,7 @@ func TestAccCluster_PoolUpgradePolicy(t *testing.T) {
 	})
 }
 
-func TestAccCluster_PoolKubeletArgs(t *testing.T) {
+func TestAccPool_KubeletArgs(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -313,7 +313,7 @@ func TestAccCluster_PoolKubeletArgs(t *testing.T) {
 	})
 }
 
-func TestAccCluster_PoolZone(t *testing.T) {
+func TestAccPool_Zone(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -342,7 +342,7 @@ func TestAccCluster_PoolZone(t *testing.T) {
 	})
 }
 
-func TestAccCluster_PoolSize(t *testing.T) {
+func TestAccPool_Size(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -366,7 +366,7 @@ func TestAccCluster_PoolSize(t *testing.T) {
 				  name    = "test-pool-size"
 				  version = "%s"
 				  cni     = "cilium"
-				  delete_additional_resources = true
+				  delete_additional_resources = false
 				  private_network_id = scaleway_vpc_private_network.test-pool-size.id
 				  auto_upgrade {
 				    enable = true
@@ -394,7 +394,7 @@ func TestAccCluster_PoolSize(t *testing.T) {
 				  name    = "test-pool-size"
 				  version = "%s"
 				  cni     = "cilium"
-				  delete_additional_resources = true
+				  delete_additional_resources = false
 				  private_network_id = scaleway_vpc_private_network.test-pool-size.id
 				  auto_upgrade {
 				    enable = true
@@ -419,7 +419,7 @@ func TestAccCluster_PoolSize(t *testing.T) {
 	})
 }
 
-func TestAccCluster_PoolPublicIPDisabled(t *testing.T) {
+func TestAccPool_PublicIPDisabled(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -449,7 +449,7 @@ func TestAccCluster_PoolPublicIPDisabled(t *testing.T) {
 				  cni     = "cilium"
 				  private_network_id = scaleway_vpc_private_network.public_ip.id
 				  tags = [ "terraform-test", "scaleway_k8s_cluster", "public_ip" ]
-				  delete_additional_resources = true
+				  delete_additional_resources = false
 				  depends_on = [scaleway_vpc_private_network.public_ip]
 				}
 			
@@ -495,7 +495,7 @@ func TestAccCluster_PoolPublicIPDisabled(t *testing.T) {
 				  cni     = "cilium"
 				  private_network_id = scaleway_vpc_private_network.public_ip.id
 				  tags = [ "terraform-test", "scaleway_k8s_cluster", "public_ip" ]
-				  delete_additional_resources = true
+				  delete_additional_resources = false
 				  depends_on = [
 					scaleway_vpc_private_network.public_ip,
 					scaleway_vpc_gateway_network.public_ip,
@@ -740,7 +740,7 @@ resource "scaleway_k8s_cluster" "minimal" {
 	cni = "calico"
 	version = "%s"
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "minimal" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.minimal.id
 }
 %s`, version, pool)
@@ -782,7 +782,7 @@ resource "scaleway_k8s_cluster" "minimal" {
 	cni = "calico"
 	version = "%s"
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "minimal" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.minimal.id
 }
 %s`, version, pool)
@@ -813,7 +813,7 @@ resource "scaleway_k8s_cluster" "placement_group" {
   cni	  = "calico"
   version = "%s"
   tags	  = [ "terraform-test", "scaleway_k8s_cluster", "placement_group" ]
-  delete_additional_resources = true
+  delete_additional_resources = false
   private_network_id = scaleway_vpc_private_network.placement_group.id
 }`, version)
 }
@@ -848,7 +848,7 @@ resource "scaleway_k8s_cluster" "placement_group_2" {
   version = "%s"
   tags	  = [ "terraform-test", "scaleway_k8s_cluster", "placement_group" ]
   region  = "nl-ams"
-  delete_additional_resources = true
+  delete_additional_resources = false
   private_network_id = scaleway_vpc_private_network.placement_group.id
 }`, version)
 }
@@ -879,7 +879,7 @@ resource "scaleway_k8s_cluster" "placement_group_2" {
   tags		= [ "terraform-test", "scaleway_k8s_cluster", "placement_group" ]
   region	= "fr-par"
   type		= "multicloud"
-  delete_additional_resources = true
+  delete_additional_resources = false
 }`, version)
 }
 
@@ -908,7 +908,7 @@ resource "scaleway_k8s_cluster" "upgrade_policy" {
 	cni = "cilium"
 	version = "%s"
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "upgrade_policy" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.upgrade_policy.id
 }`, maxSurge, maxUnavailable, version)
 }
@@ -937,7 +937,7 @@ resource "scaleway_k8s_cluster" "kubelet_args" {
 	cni = "cilium"
 	version = "%s"
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "kubelet_args" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.kubelet_args.id
 }`, maxPods, version)
 }
@@ -964,7 +964,7 @@ resource "scaleway_k8s_cluster" "zone" {
 	cni = "cilium"
 	version = "%s"
 	tags = [ "terraform-test", "scaleway_k8s_cluster", "zone" ]
-	delete_additional_resources = true
+	delete_additional_resources = false
 	private_network_id = scaleway_vpc_private_network.zone.id
 }`, zone, version)
 }