Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useInfiniteDataLoader #2282

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Conversation

DorianMaliszewski
Copy link
Member

Implement useInfiniteDataLoader to handle Load More on our UI

Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: 28aad5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/use-dataloader Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DorianMaliszewski DorianMaliszewski added the enhancement New feature or request label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 87.77778% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (33bc16f) to head (28aad5f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/use-dataloader/src/useInfiniteDataLoader.ts 92.77% 2 Missing and 4 partials ⚠️
packages/use-dataloader/src/DataLoaderProvider.tsx 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   77.86%   78.87%   +1.01%     
==========================================
  Files          25       26       +1     
  Lines         768      857      +89     
  Branches       97      110      +13     
==========================================
+ Hits          598      676      +78     
- Misses        162      169       +7     
- Partials        8       12       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@alexandre-combemorel alexandre-combemorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much time to fully deep dive into the code flow. But happy to test it with our use cases. LGTM

@DorianMaliszewski DorianMaliszewski merged commit d153ea4 into main Mar 20, 2025
7 checks passed
@DorianMaliszewski DorianMaliszewski deleted the feat/infinite-queries branch March 20, 2025 15:32
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants