feat(lb): add ssl bridging annotations #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtherin
approved these changes
Aug 26, 2024
louisportay
approved these changes
Aug 26, 2024
louisportay
reviewed
Aug 26, 2024
| func getSSLBridging(service *v1.Service, nodePort int32) (*bool, error) { | ||
| tlsEnabled, found := service.Annotations[serviceAnnotationLoadBalancerHTTPBackendTLS] | ||
| if !found { | ||
| return nil, nil |
There was a problem hiding this comment.
just wondering, this return just does nothing ?
There was a problem hiding this comment.
same pattern as the other, if no annotation set, we return the default (unset)
There was a problem hiding this comment.
but agreed that passing an empty string to isPortInRange would render the same result.
I'll keep the check as it's more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.