Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): use sbs api for block volumes #4435

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jan 15, 2025

b and block volume options are now the same as sbs. Instance b_ssd is no longer supported.

@Codelax Codelax added instance Instance issues, bugs and feature requests sbs Scaleway Block Storage issues, bugs and feature requests labels Jan 15, 2025
@Codelax Codelax changed the title feat(block): add volume wait command feat(instance): use sbs api for block volumes Jan 21, 2025
@Codelax Codelax force-pushed the feat/root-volume-sbs-default branch from 79640bc to f320569 Compare January 21, 2025 10:42
@Codelax Codelax force-pushed the feat/root-volume-sbs-default branch from 31a27fb to 839d2d0 Compare January 23, 2025 13:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.79%. Comparing base (5bf53e0) to head (d7cb965).
Report is 455 commits behind head on master.

Files with missing lines Patch % Lines
...spaces/instance/v1/custom_server_create_builder.go 75.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4435      +/-   ##
==========================================
- Coverage   75.45%   70.79%   -4.67%     
==========================================
  Files         202      299      +97     
  Lines       44323    66149   +21826     
==========================================
+ Hits        33444    46828   +13384     
- Misses       9653    17674    +8021     
- Partials     1226     1647     +421     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review January 23, 2025 13:48
@remyleone remyleone added this pull request to the merge queue Jan 23, 2025
Merged via the queue into scaleway:master with commit 9850cc4 Jan 23, 2025
13 checks passed
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests sbs Scaleway Block Storage issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants