-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instance): use sbs api for block volumes #4435
Merged
remyleone
merged 7 commits into
scaleway:master
from
Codelax:feat/root-volume-sbs-default
Jan 23, 2025
Merged
feat(instance): use sbs api for block volumes #4435
remyleone
merged 7 commits into
scaleway:master
from
Codelax:feat/root-volume-sbs-default
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codelax
added
instance
Instance issues, bugs and feature requests
sbs
Scaleway Block Storage issues, bugs and feature requests
labels
Jan 15, 2025
Codelax
changed the title
feat(block): add volume wait command
feat(instance): use sbs api for block volumes
Jan 21, 2025
Codelax
force-pushed
the
feat/root-volume-sbs-default
branch
from
January 21, 2025 10:42
79640bc
to
f320569
Compare
Codelax
force-pushed
the
feat/root-volume-sbs-default
branch
from
January 23, 2025 13:25
31a27fb
to
839d2d0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4435 +/- ##
==========================================
- Coverage 75.45% 70.79% -4.67%
==========================================
Files 202 299 +97
Lines 44323 66149 +21826
==========================================
+ Hits 33444 46828 +13384
- Misses 9653 17674 +8021
- Partials 1226 1647 +421 ☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b
andblock
volume options are now the same assbs
. Instanceb_ssd
is no longer supported.