Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object): disable command in console #4151

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Oct 1, 2024

close #4099

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 89.13043% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (5bf53e0) to head (5213d8d).
Report is 277 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/object/v1/custom_marshaler.go 81.48% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4151      +/-   ##
==========================================
- Coverage   75.45%   72.50%   -2.95%     
==========================================
  Files         202      291      +89     
  Lines       44323    54236    +9913     
==========================================
+ Hits        33444    39324    +5880     
- Misses       9653    13298    +3645     
- Partials     1226     1614     +388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as draft October 1, 2024 09:43
@Laure-di Laure-di self-assigned this Oct 1, 2024
@Laure-di Laure-di marked this pull request as ready for review October 1, 2024 14:14
@Codelax Codelax added this pull request to the merge queue Oct 9, 2024
Merged via the queue into scaleway:master with commit 5f05b15 Oct 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm: object commands crash
3 participants