Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedibox): change verbs for options #4110

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat(dedibox): change verbs for options #4110

merged 1 commit into from
Sep 9, 2024

Conversation

scaleway-bot
Copy link
Contributor

No description provided.

@github-actions github-actions bot added domain Domains issues, bugs and feature requests container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests billing Billing issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests dedibox Dedibox issues, bugs and feature requests sdb labels Sep 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.43%. Comparing base (5bf53e0) to head (f290a03).
Report is 243 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/dedibox/v1/dedibox_cli.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4110      +/-   ##
==========================================
- Coverage   75.45%   72.43%   -3.03%     
==========================================
  Files         202      289      +87     
  Lines       44323    53837    +9514     
==========================================
+ Hits        33444    38995    +5551     
- Misses       9653    13243    +3590     
- Partials     1226     1599     +373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone changed the title feat: update generated APIs feat(dedibox): change verbs for options Sep 9, 2024
@remyleone remyleone added this pull request to the merge queue Sep 9, 2024
Merged via the queue into scaleway:master with commit b3b142e Sep 9, 2024
13 checks passed
@remyleone remyleone deleted the manual_1725889303 branch September 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@jremy42 jremy42 Awaiting requested review from jremy42 jremy42 is a code owner

@Codelax Codelax Awaiting requested review from Codelax Codelax is a code owner

@yfodil yfodil Awaiting requested review from yfodil yfodil is a code owner

@Laure-di Laure-di Awaiting requested review from Laure-di Laure-di is a code owner

Assignees
No one assigned
Labels
apple-silicon Apple Silicon issues, bugs and feature requests billing Billing issues, bugs and feature requests container Container issues, bugs and feature requests dedibox Dedibox issues, bugs and feature requests domain Domains issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests sdb secret Managed Secret Manager issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scaleway-bot @codecov-commenter @remyleone