Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for gci, sloglint, loggercheck, grouper #4058

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@github-actions github-actions bot added registry Managed Container Registry issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests iot IoT issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests iam IAM issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests baremetal vpcgw labels Aug 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.40%. Comparing base (5bf53e0) to head (be9e133).
Report is 272 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (be9e133). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (be9e133)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4058      +/-   ##
==========================================
- Coverage   75.45%   69.40%   -6.06%     
==========================================
  Files         202      291      +89     
  Lines       44323    55620   +11297     
==========================================
+ Hits        33444    38602    +5158     
- Misses       9653    15442    +5789     
- Partials     1226     1576     +350     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Laure-di
Laure-di previously approved these changes Aug 21, 2024
@Laure-di Laure-di added this pull request to the merge queue Aug 21, 2024
@Laure-di Laure-di removed this pull request from the merge queue due to a manual request Aug 21, 2024
@Laure-di Laure-di added this pull request to the merge queue Aug 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 21, 2024
@remyleone remyleone added this pull request to the merge queue Aug 22, 2024
Merged via the queue into scaleway:master with commit edd76d8 Aug 22, 2024
13 checks passed
@remyleone remyleone deleted the gci branch August 22, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple-silicon Apple Silicon issues, bugs and feature requests baremetal container Container issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests iam IAM issues, bugs and feature requests instance Instance issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw webhosting Webhosting issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants