Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): routed ip support #3297

Merged
merged 10 commits into from
Jul 27, 2023
Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 21, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Jul 21, 2023
@Codelax Codelax self-assigned this Jul 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #3297 (b2913c3) into master (b2aa437) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 80.35%.

@@           Coverage Diff           @@
##           master    #3297   +/-   ##
=======================================
  Coverage   75.62%   75.63%           
=======================================
  Files         171      171           
  Lines       38121    38160   +39     
=======================================
+ Hits        28828    28861   +33     
- Misses       8252     8257    +5     
- Partials     1041     1042    +1     
Files Changed Coverage Δ
internal/human/marshal_func.go 35.81% <0.00%> (-0.75%) ⬇️
...nal/namespaces/instance/v1/custom_server_create.go 81.27% <76.00%> (-0.18%) ⬇️
internal/namespaces/instance/v1/custom.go 98.22% <100.00%> (+0.01%) ⬆️
internal/namespaces/instance/v1/custom_server.go 80.06% <100.00%> (+0.47%) ⬆️

@Codelax Codelax marked this pull request as ready for review July 24, 2023 07:42
@Codelax Codelax marked this pull request as draft July 24, 2023 07:42
@Codelax Codelax force-pushed the feat/ip-mobility branch 2 times, most recently from 30ea197 to 813560f Compare July 24, 2023 12:52
@Codelax Codelax marked this pull request as ready for review July 27, 2023 08:33
@quantumsheep quantumsheep self-requested a review July 27, 2023 13:17
@Codelax Codelax added this pull request to the merge queue Jul 27, 2023
Merged via the queue into scaleway:master with commit 7aa5861 Jul 27, 2023
12 checks passed
@Codelax Codelax deleted the feat/ip-mobility branch July 27, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants