fix(core): add disableCheckVersion option to commands (#2983)

scaleway · Apr 3, 2023 · cb52f9d · cb52f9d
1 parent d163031
commit cb52f9d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/internal/core/build_info.go b/internal/core/build_info.go
@@ -57,7 +57,9 @@ func (b *BuildInfo) GetUserAgent() string {
 }
 
 func (b *BuildInfo) checkVersion(ctx context.Context) {
-	if !b.IsRelease() || ExtractEnv(ctx, scwDisableCheckVersionEnv) == "true" {
+	cmd := extractMeta(ctx).command
+	cmdDisableCheckVersion := cmd != nil && cmd.DisableVersionCheck
+	if !b.IsRelease() || ExtractEnv(ctx, scwDisableCheckVersionEnv) == "true" || cmdDisableCheckVersion {
 		ExtractLogger(ctx).Debug("skipping check version")
 		return
 	}

diff --git a/internal/core/command.go b/internal/core/command.go
@@ -35,6 +35,9 @@ type Command struct {
 	// DisableTelemetry disable telemetry for the command.
 	DisableTelemetry bool
 
+	// DisableVersionCheck disable the version check to avoid superfluous message
+	DisableVersionCheck bool
+
 	// Hidden hides the command form usage and auto-complete.
 	Hidden bool
 

diff --git a/internal/namespaces/autocomplete/autocomplete.go b/internal/namespaces/autocomplete/autocomplete.go
@@ -19,14 +19,20 @@ import (
 )
 
 func GetCommands() *core.Commands {
-	return core.NewCommands(
+	cmds := core.NewCommands(
 		autocompleteRootCommand(),
 		autocompleteInstallCommand(),
 		autocompleteCompleteBashCommand(),
 		autocompleteCompleteFishCommand(),
 		autocompleteCompleteZshCommand(),
 		autocompleteScriptCommand(),
 	)
+
+	for _, cmd := range cmds.GetAll() {
+		cmd.DisableVersionCheck = true
+	}
+
+	return cmds
 }
 
 func autocompleteRootCommand() *core.Command {