Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vpc): skip static address late init #89

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Aug 7, 2024

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@yfodil yfodil added bug Something isn't working vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Aug 7, 2024
@yfodil yfodil self-assigned this Aug 7, 2024
@yfodil yfodil linked an issue Aug 7, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@f8d5767). Learn more about missing BASE report.

Files Patch % Lines
apis/vpc/v1alpha1/zz_gatewaynetwork_terraformed.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #89   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?     354           
  Lines           ?   34061           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?   34061           
  Partials        ?       0           
Flag Coverage Δ
unittests 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Aug 7, 2024
Merged via the queue into scaleway:main with commit 1d90016 Aug 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of a GatewayNetwork with ipamConfig failed
3 participants