Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set jdk to 17 #100

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Set jdk to 17 #100

merged 3 commits into from
Oct 7, 2024

Conversation

artem-v
Copy link
Contributor

@artem-v artem-v commented Oct 6, 2024 •
edited
Loading

Set target to 17 as well. So both source and target are set to 17.

@artem-v artem-v changed the title Test ci branch Set jdk source to 17 Oct 6, 2024
@artem-v artem-v changed the title Set jdk source to 17 Set jdk to 17 Oct 6, 2024
@artem-v artem-v merged commit 69be0bc into master Oct 7, 2024
2 checks passed
@artem-v artem-v deleted the test-ci-branch branch October 7, 2024 05:41
@aharonha
Copy link
Contributor

aharonha commented Oct 14, 2024 •
edited
Loading

PR #100 is a great number to switch version of jdk 😄

@artem-v
Copy link
Contributor Author

artem-v commented Oct 14, 2024

PR #100 is a great number to switch version of jdk 😄

Yes, good point BTW. Looks like it's a sign that we are on the right track .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-lazebnyi dmytro-lazebnyi Awaiting requested review from dmytro-lazebnyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artem-v @aharonha