bugfix: Infer arg type properly when complex #7158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
infer-method-2
branch
3 times, most recently
from
4330f04 to
1deaedd
Compare
kasiaMarek
reviewed
Jan 27, 2025
| @@ -177,6 +178,33 @@ final class InferredMethodProvider( | |||
| } else None | |||
| } | |||
|
|
|||
| private def inferArgType(arg: Tree): String = { | |||
There was a problem hiding this comment.
This won't work for lambda expression with short syntax, like:
List(...).map(<<method>>)right? But it also shouldn't call this method in such a case, right?
There was a problem hiding this comment.
Yeah, it will not be called in that case. This is strictly in cases where we want to calculate parameter types of the non existing function.
tgodzik
force-pushed
the
infer-method-2
branch
from
1deaedd to
635aab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6954