bugfix: Work around fansi escaping issues #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, some error messages might have been not able to be printed due to a bug in fansi com-lihaoyi/fansi#46 Now, we added a workaround that should help out here. Fixes scalameta#730
|
@tgodzik would it be easy to add a test for this? I assume we can throw an exception with a broken fansi string in a markdown document? |
tgodzik
force-pushed
the
workaround-fansi
branch
5 times, most recently
from
90cab27
to
a1dde47
Compare
tgodzik
force-pushed
the
workaround-fansi
branch
from
a1dde47
to
47f7754
Compare
Alright, I finally managed to get the test working. I also moved the CliSuite to tests, since it was not being even run at all 😨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some error messages might have been not able to be printed due to a bug in fansi com-lihaoyi/fansi#46
Now, we added a workaround that should help out here.
Fixes #730