Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting from tree-sitter parser #961

Merged
merged 7 commits into from
Dec 8, 2023

Conversation

rochala
Copy link
Collaborator

@rochala rochala commented Oct 6, 2023

No description provided.

@rochala rochala requested a review from sjrd October 6, 2023 11:53
Copy link
Contributor

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one overall comment: where do the two .wasm files come from? How do we reconstruct them? Could we download them during the build process instead of burning them into git?

@keynmol
Copy link

keynmol commented Oct 17, 2023

I'd highly recommend building wasm files on demand directly from the grammar, which is just npm exec -c 'tree-sitter build-wasm' in the tree-sitter-scala repo: https://github.com/tree-sitter/tree-sitter-scala/

Additionally, I'd also recommend not hardcoding the highlighting queries but rather picking them up straight out of the repo as well.

We constantly have troubles with highlight queries in nvim-treesitter repo going out of sync with the queries we have in the grammar repo (which is the source of truth, as we test highlighting against the parser code)

upd: super excited for this!

@rochala rochala enabled auto-merge (squash) December 7, 2023 16:37
@rochala rochala disabled auto-merge December 8, 2023 10:24
@rochala rochala merged commit 54dfbb2 into scalacenter:main Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants